Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ordered maps #695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use ordered maps #695

wants to merge 2 commits into from

Conversation

fenollp
Copy link
Collaborator

@fenollp fenollp commented Dec 4, 2022

Fixes #645

@fenollp fenollp changed the title WIP needs un/marshalling Use ordered maps Dec 4, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2022
View reviewed changes
openapi3/loader.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2022
View reviewed changes
openapi3/loader.go Fixed Show fixed Hide fixed
@fenollp fenollp force-pushed the issue645 branch 3 times, most recently from 391b9a7 to 1afb638 Compare December 19, 2022 16:59
@bitomaxsp
Copy link

bitomaxsp commented Dec 20, 2022 •
edited
Loading

What kind of help is needed here? We (@northvolt) are super eager to see that released :)

@fenollp
Copy link
Collaborator Author

fenollp commented Dec 20, 2022

Hey @bitomaxsp I'd love some help! Right now I'm stuck solving this:

FAIL | Issue301 (0.00s)
     | panic: runtime error: invalid memory address or nil pointer dereference [recovered]
     | 	panic: runtime error: invalid memory address or nil pointer dereference
     | [signal SIGSEGV: segmentation violation code=0x1 addr=0x58 pc=0x805850]
     | goroutine 19 [running]:
     | testing.tRunner.func1.2({0x888260, 0xc6abe0})
     | 	/snap/go/10008/src/testing/testing.go:1396 +0x24e
     | testing.tRunner.func1()
     | 	/snap/go/10008/src/testing/testing.go:1399 +0x39f
     | panic({0x888260, 0xc6abe0})
     | 	/snap/go/10008/src/runtime/panic.go:884 +0x212
     | github.com/getkin/kin-openapi/openapi3.TestIssue301(0x0?)
     | 	/home/pete/wefwefwef/kin-openapi.git/openapi3/issue301_test.go:32 +0x250
     | testing.tRunner(0xc0001ac820, 0x947b40)
     | 	/snap/go/10008/src/testing/testing.go:1446 +0x10b
     | created by testing.(*T).Run
     | 	/snap/go/10008/src/testing/testing.go:1493 +0x35f
FAIL | 	github.com/getkin/kin-openapi/openapi3	0.005s

From there I believe the design satisfies me. The rest of the work should be straightforward(TM)!

Could you describe your needs WRT this patch a bit?

@fenollp fenollp mentioned this pull request Jan 30, 2023
Closed
@fenollp fenollp mentioned this pull request Feb 9, 2023
Closed
@fenollp fenollp mentioned this pull request Jun 23, 2023
Closed
@fenollp fenollp mentioned this pull request Nov 25, 2023
Merged
@fenollp fenollp force-pushed the issue645 branch 5 times, most recently from 235c915 to 82a23b0 Compare November 26, 2023 16:34
@fenollp fenollp marked this pull request as ready for review November 28, 2023 20:43
@fenollp
Use ordered maps
db8be28 
Signed-off-by: Pierre Fenoll <[email protected]>
@fenollp
wip
d38ff38 
Signed-off-by: Pierre Fenoll <[email protected]>
@fenollp fenollp mentioned this pull request Mar 22, 2024
Open
@takanuva15
Copy link

Hi, did you have any luck fixing this issue? Looks like I encountered the same circular reference problem when trying to use this library with a large complex schema like in #814

@fenollp fenollp mentioned this pull request May 13, 2024
Merged
@renom
Copy link

renom commented Aug 9, 2024

Is it going to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please user OrderedMap instead of the golang's map
4 participants
@fenollp @bitomaxsp @takanuva15 @renom